Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wafv2_ip_set - fix bugs with changing description #1211

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jun 3, 2022

SUMMARY
  • updating just the description didn't update the changed state
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

wafv2_ip_set

ADDITIONAL INFORMATION

@tremble tremble force-pushed the wafv2_ip_set/description branch from b919d34 to 8855277 Compare June 3, 2022 19:21
@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Jun 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

ansible-galaxy-importer FAILURE in 3m 59s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 56s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 21s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 39s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 12m 35s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 43s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 11m 39s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 12s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 5m 40s
✔️ ansible-test-splitter SUCCESS in 2m 23s
✔️ integration-community.aws-1 SUCCESS in 6m 17s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble requested a review from markuman June 4, 2022 07:33
@markuman markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Jun 4, 2022
@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Jun 4, 2022
@tremble
Copy link
Contributor Author

tremble commented Jun 4, 2022

@markuman FYI the PR won't be able to automatically backport because #1205 hasn't been backported. I'll manually backport once this PR is merged.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

ansible-galaxy-importer FAILURE in 5m 01s (non-voting)
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 46s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 13m 47s
✔️ ansible-test-sanity-docker-stable-2.9 SUCCESS in 11m 18s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 49s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 16s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 5m 34s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 05s
✔️ ansible-test-splitter SUCCESS in 2m 23s
✔️ integration-community.aws-1 SUCCESS in 14m 44s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b6ed8d5 into ansible-collections:main Jun 4, 2022
@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

tremble added a commit to tremble/community.aws that referenced this pull request Jun 4, 2022
…s#1211)

wafv2_ip_set - fix bugs with changing description

SUMMARY

updating just the description didn't update the changed state

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_ip_set
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 7, 2022
[stable-3] wafv2_ip_set - fix bugs with changing description

Manual backport of #1211
SUMMARY
Updating just the description didn't update the changed state
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_ip_set
ADDITIONAL INFORMATION
Reviewed-by: Markus Bergholz

Reviewed-by: Alina Buzachis <None>
patchback bot pushed a commit that referenced this pull request Jun 7, 2022
[stable-3] wafv2_ip_set - fix bugs with changing description

Manual backport of #1211
SUMMARY
Updating just the description didn't update the changed state
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_ip_set
ADDITIONAL INFORMATION
Reviewed-by: Markus Bergholz

Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 7a5ece4)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 8, 2022
)

[PR #1214/7a5ece48 backport][stable-2] wafv2_ip_set - fix bugs with changing description

This is a backport of PR #1214 as merged into stable-3 (7a5ece4).
Manual backport of #1211
SUMMARY
Updating just the description didn't update the changed state
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
wafv2_ip_set
ADDITIONAL INFORMATION
Reviewed-by: Markus Bergholz

Reviewed-by: Markus Bergholz <[email protected]>
@tremble tremble deleted the wafv2_ip_set/description branch July 7, 2022 19:23
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
ec2_snapshot_info/tests: add unit-tests

Depends-On: ansible-collections#1234
Depends-On: ansible-collections#1235
SUMMARY


Add the unit-test coverage of the ec2_snapshot_info module.
break up list_ec2_snapshots to move connection.describe_snapshots to  separate method.


COMPONENT NAME

ec2_snapshot_info
ADDITIONAL INFO
latest CI run coverage report  plugins_modules_ec2_snapshot_info_py.html

Reviewed-by: Gonéri Le Bouder <[email protected]>
Reviewed-by: Mandar Kulkarni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants